MongoDB: support username/password credentials #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stscoundrel
force-pushed
the
mongodb-credentials
branch
6 times, most recently
from
fd678b5 to
aaaa3b5
Compare
Previously MongoDB did not support passing credentials, although the underlying image does support them. However, as the current container implementation always sets up replication, auth gets a bit more complicated. A keyfile neds to be generated and a wait needs to be added for auth setup. In future major version, it would make sense to drop the automatic replication from constructor and move it to option like withReplication Closes testcontainers#988
stscoundrel
force-pushed
the
mongodb-credentials
branch
2 times, most recently
from
d638c2b to
cec67f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously MongoDB did not support passing credentials, although the underlying image does support them.
However, as the current container implementation always sets up replication, auth gets a bit more complicated. A keyfile neds to be generated and a wait needs to be added for auth setup.
In future major version, it would make sense to drop the automatic replication from constructor and move it to option like withReplication
Closes testcontainers#988